Re: pgbench - allow to create partitioned tables

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - allow to create partitioned tables
Date: 2019-09-19 04:55:32
Message-ID: alpine.DEB.2.21.1909190645190.1585@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Amit,

>> Yes, on -i it will fail because the syntax will not be recognized.
> Maybe we should be checking the server version, which would allow to
> produce more useful error messages when these options are used against
> older servers, like
> if (sversion < 10000)
> fprintf(stderr, "cannot use --partitions/--partitions-method
> against servers older than 10");
> We would also have to check that partition-method=hash is not used against v10.
> Maybe overkill?

Yes, I think so: the error detection and messages would be more or less
replicated from the server and would vary from version to version.

I do not think that it is worth going this path because the use case is
virtually void as people in 99.9% of cases would use a pgbench matching
the server version. For those who do not, the error message should be
clear enough to let them guess what the issue is. Also, it would be

One thing we could eventually do is just to check pgbench version against
the server version like psql does and output a generic warning if they
differ, but franckly I do not think it is worth the effort: ISTM that
nobody ever complained about such issues. Also, that would be matter for
another patch.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2019-09-19 06:05:56 Re: Zedstore - compressed in-core columnar storage
Previous Message Smith, Peter 2019-09-19 04:46:27 RE: Proposal: Add more compile-time asserts to expose inconsistencies.