| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - allow to create partitioned tables |
| Date: | 2019-09-19 02:10:16 |
| Message-ID: | CA+HiwqHL_QrVf2cNoA4uhR2oG=yRz6W8b_4hZABX3MpAYM5qiQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Fabien,
On Thu, Sep 19, 2019 at 2:03 AM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > If that is the case, then I think if user gives --partitions for the old
> > server version, it will also give an error?
>
> Yes, on -i it will fail because the syntax will not be recognized.
Maybe we should be checking the server version, which would allow to
produce more useful error messages when these options are used against
older servers, like
if (sversion < 10000)
fprintf(stderr, "cannot use --partitions/--partitions-method
against servers older than 10");
We would also have to check that partition-method=hash is not used against v10.
Maybe overkill?
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-09-19 02:25:23 | Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index. |
| Previous Message | Michael Paquier | 2019-09-19 02:04:22 | Re: [HACKERS] [PATCH] pageinspect function to decode infomasks |