Re: [PATCH v4] Add \warn to psql

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: David Fetter <david(at)fetter(dot)org>
Cc: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v4] Add \warn to psql
Date: 2019-05-01 10:02:48
Message-ID: alpine.DEB.2.21.1905011201200.2241@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>>> I guess that you have a verbose ~/.psqlrc.
>>>
>>> Can you try with adding -X to psql option when calling psql from the tap
>>> test?
>>
>> Ah, true. This patch works for me:
>>
>> diff --git a/src/bin/psql/t/001_psql.pl b/src/bin/psql/t/001_psql.pl
>> index 32dd43279b..637baa94c9 100644
>> --- a/src/bin/psql/t/001_psql.pl
>> +++ b/src/bin/psql/t/001_psql.pl
>> @@ -20,7 +20,7 @@ sub psql
>> {
>> local $Test::Builder::Level = $Test::Builder::Level + 1;
>> my ($opts, $stat, $in, $out, $err, $name) = @_;
>> - my @cmd = ('psql', split /\s+/, $opts);
>> + my @cmd = ('psql', '-X', split /\s+/, $opts);
>> $node->command_checks_all(\(at)cmd, $stat, $out, $err, $name, $in);
>> return;
>> }
>
> Please find attached :)

Good. Works for me, even with a verbose .psqlrc. Switched back to ready.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kukushkin 2019-05-01 12:13:10 Re: walsender vs. XLogBackgroundFlush during shutdown
Previous Message David Fetter 2019-05-01 07:38:57 Re: [PATCH v4] Add \warn to psql