Re: [PATCH v4] Add \warn to psql

On Wed, May 01, 2019 at 10:05:44AM +0300, Arthur Zakirov wrote:
> (Unfortunately I accidentally sent my previous two messages using my personal
> email address because of my email client configuration. This address is not
> verified by PostgreSQL.org services and messages didn't reach hackers mailing
> lists, so I recent latest message).
>
> On Tue, Apr 30, 2019 at 4:46 PM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > > Unfortunately new TAP test doesn't pass on my machine. I'm not good at Perl
> > > and didn't get the reason of the failure quickly.
> >
> > I guess that you have a verbose ~/.psqlrc.
> >
> > Can you try with adding -X to psql option when calling psql from the tap
> > test?
>
> Ah, true. This patch works for me:
>
> diff --git a/src/bin/psql/t/001_psql.pl b/src/bin/psql/t/001_psql.pl
> index 32dd43279b..637baa94c9 100644
> --- a/src/bin/psql/t/001_psql.pl
> +++ b/src/bin/psql/t/001_psql.pl
> @@ -20,7 +20,7 @@ sub psql
> {
> local $Test::Builder::Level = $Test::Builder::Level + 1;
> my ($opts, $stat, $in, $out, $err, $name) = @_;
> - my @cmd = ('psql', split /\s+/, $opts);
> + my @cmd = ('psql', '-X', split /\s+/, $opts);
> $node->command_checks_all(\(at)cmd, $stat, $out, $err, $name, $in);
> return;
> }

Please find attached :)

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate