Re: Offline enabling/disabling of data checksums

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Offline enabling/disabling of data checksums
Date: 2019-03-17 17:17:50
Message-ID: alpine.DEB.2.21.1903171816210.2506@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> You have one error at the end of update_controlfile(), where close()
> could issue a frontend-like error for the backend, calling exit() on the
> way. That's not good. (No need to send a new patch, I'll fix it
> myself.)

Indeed. I meant to merge the "if (close(fd))", but ended merging the error
generation as well.

--
Fabien

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2019-03-17 18:13:03 Re: Fix XML handling with DOCTYPE
Previous Message Tom Lane 2019-03-17 17:16:31 Re: Fix XML handling with DOCTYPE