Re: libpq host/hostaddr/conninfo inconsistencies

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq host/hostaddr/conninfo inconsistencies
Date: 2019-02-21 14:27:21
Message-ID: alpine.DEB.2.21.1902211521230.27203@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Robert,

>>> (2) you are not against improving the documentation, although you find it
>>> clear enough already, but you agree that some people could get confused.
>>> The attached patch v4 only improves the documentation so that it reflects
>>> what the implementation really does. I think it too bad to leave out the
>>> user-friendly aspects of the patch, though.
>> Robert, any chance you could opine on the doc patch, given that's your
>> suggested direction?
> I find it to be a more change than we really need, and I'm not sure
> how much it helps to clarify the issue at hand. Here is a simpler
> change which seems like it might do the trick (or maybe not, let's see
> what others think).

It is a minimal diff on "hostaddr" documentation which clarifies what is
its intended use. I'm okay with it.

However, it does not discuss that an IP can (and should, IMHO) be given
through "host" if the point is to specify the target by its IP rather than
a lookup shortcut.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2019-02-21 14:30:50 Re: shared-memory based stats collector
Previous Message Stephen Frost 2019-02-21 13:50:38 Re: WAL insert delay settings