|From:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Cc:||Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Raúl Marín Rodríguez <rmrodriguez(at)carto(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: [PATCH] pgbench tap tests fail if the path contains a perl special character|
|Views:||Raw Message | Whole Thread | Download mbox|
> I did a little bit of googling on this subject last night, and it
> seems that at least some people believe that the answer is to not
> use glob, period, but read the directory for yourself.
> As a short-term move to un-break the buildfarm, I'm just going to
> revert that patch altogether.
> We can reapply it once we've figured out how to do the glob part correctly.
Here is a proposal patch which:
- works around pgbench command splitting on spaces,
if postgres sources are in a strangely named directory…
I tested within a directory named "pg .* dir".
- works aroung "glob" lack of portability by reading the directory
directly and filtering with a standard re (see list_files).
- adds a few comments
- removes a spurious i option on an empty re
|Next Message||Darafei Komяpa Praliaskouski||2019-01-22 08:58:42||Re: Allowing extensions to find out the OIDs of their member objects|
|Previous Message||Michael Paquier||2019-01-22 08:08:52||index_build does not need its isprimary argument|