Re: [PATCH] pgbench tap tests fail if the path contains a perl special character

Hello Tom,

> Well, glob does have some metacharacters, so not doing any quoting
> at all still leaves us with failure modes.
>
> I did a little bit of googling on this subject last night, and it
> seems that at least some people believe that the answer is to not
> use glob, period, but read the directory for yourself.

Yep, would work, it can then be filtered with standard regexpr, although
it will take a few lines (opendir/grep on readdir/closedir).

> Maybe there's a better way, but the breakage around backslashes doesn't
> really leave me hopeful.

Indeed. I was thinking of defining my own quote function, but without
being convinced that it is such a good idea.

> As a short-term move to un-break the buildfarm, I'm just going to
> revert that patch altogether.

I was considering to suggest that, so I'm ok with that.

> We can reapply it once we've figured out how to do the glob part
> correctly.

Yep. No need to spend time much on that, I'll have a look at it, although
not right now, allow me a few days.

--
Fabien.