>> -#ifdef HAVE_SYS_SELECT_H >> +#ifdef PGBENCH_USE_SELECT /* force use of select(2)? */ >> +#undef HAVE_PPOLL >> +#endif >> +#ifdef HAVE_PPOLL >> +#include <poll.h> >> +#elif defined(HAVE_SYS_SELECT_H) >> +#define POLL_USING_SELECT > > (random thing noticed while going through patches) > > It strikes me as a bad idea to undefine configure selected > symbols. Postgres header might rely on them. It also strikes me as > entirely unnecessary here.
Yes, I though about this one but let it pass. Indeed, it would be sufficient to not load "poll.h" when select is forced, without undefining the configure setting.