| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Rady, Doug" <radydoug(at)amazon(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |
| Date: | 2018-03-01 08:34:04 |
| Message-ID: | 20180301083404.z2sbnjdaw7gxvz6x@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-01-28 23:02:57 +0000, Rady, Doug wrote:
> diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
> index 31ea6ca06e..689f15a772 100644
> --- a/src/bin/pgbench/pgbench.c
> +++ b/src/bin/pgbench/pgbench.c
> @@ -44,7 +44,13 @@
> #include <signal.h>
> #include <time.h>
> #include <sys/time.h>
> -#ifdef HAVE_SYS_SELECT_H
> +#ifdef PGBENCH_USE_SELECT /* force use of select(2)? */
> +#undef HAVE_PPOLL
> +#endif
> +#ifdef HAVE_PPOLL
> +#include <poll.h>
> +#elif defined(HAVE_SYS_SELECT_H)
> +#define POLL_USING_SELECT
(random thing noticed while going through patches)
It strikes me as a bad idea to undefine configure selected
symbols. Postgres header might rely on them. It also strikes me as
entirely unnecessary here.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-01 08:53:25 | Re: [PATCH] Find additional connection service files in pg_service.conf.d directory |
| Previous Message | Andres Freund | 2018-03-01 08:26:45 | Re: pgbench - add \if support |