Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: "Rady, Doug" <radydoug(at)amazon(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
Date: 2018-01-29 08:58:59
Message-ID: alpine.DEB.2.20.1801290953280.31442@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Doug,

> I'm not sure why you do the following trick, could you explain?
> +#undef USE_SELECT
> +#define USE_SELECT
>
> This was due to compiler complaint about USE_SELECT being redefined.
> Have replaced that "trick" with a new #define POLL_USING_SELECT which is used elsewhere in pgbench instead.

Ok, why not.

Another option to avoid the warning and a new name could have been to
"#ifndef X #define X #endif /* !X */"

Patch applies cleanly, compiles cleanly for both options, local & global
"make check" ok.

Switched to "Ready".

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-01-29 09:01:54 Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)
Previous Message Konstantin Knizhnik 2018-01-29 08:57:36 Re: Built-in connection pooling