Re: Re: [HACKERS] pgbench randomness initialization

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Chapman Flack <chap(at)anastigmatix(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [HACKERS] pgbench randomness initialization
Date: 2018-01-10 10:00:24
Message-ID: alpine.DEB.2.20.1801101038340.2283@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> This is a simple patch that does what it says on the tin. I ran into
> trouble with the pgbench TAP test *even before applying the patch*, but
> only because I was doing a VPATH build as a user without 'write'
> on the source tree ( tried to make pgbench
> create log files there). Bad me. Oddly, that was the only test in the
> whole tree to have such an issue, so here I add a pre-patch to fix that.
> Now my review needs a review. :)

Yep. I find the multiple chdir solution a little bit too extreme.

ISTM that it should rather add the correct path to --log-prefix by
prepending $node->basedir, like the pgbench function does for -f scripts.

See attached.


Attachment Content-Type Size
pgbench-vpath-2.patch text/x-diff 1.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-01-10 12:27:19 Re: Re: [HACKERS] pgbench randomness initialization
Previous Message Konstantin Knizhnik 2018-01-10 09:54:45 Re: [HACKERS] Surjective functional indexes