From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Chapman Flack <chap(at)anastigmatix(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] pgbench randomness initialization |
Date: | 2018-02-28 23:01:55 |
Message-ID: | 1518.1519858915@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> This is a simple patch that does what it says on the tin. I ran into
>> trouble with the pgbench TAP test *even before applying the patch*, but
>> only because I was doing a VPATH build as a user without 'write'
>> on the source tree (001_pgbench_with_server.pl tried to make pgbench
>> create log files there). Bad me. Oddly, that was the only test in the
>> whole tree to have such an issue, so here I add a pre-patch to fix that.
>> Now my review needs a review. :)
> Yep. I find the multiple chdir solution a little bit too extreme.
> ISTM that it should rather add the correct path to --log-prefix by
> prepending $node->basedir, like the pgbench function does for -f scripts.
> See attached.
Hm ... so I tried to replicate this problem, and failed to: the log files
get made under the VPATH build directory, as desired, even without this
patch. Am I doing something wrong, or is this platform-dependent somehow?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Euler Taveira | 2018-02-28 23:03:02 | row filtering for logical replication |
Previous Message | Tom Lane | 2018-02-28 22:54:43 | VPATH build from a tarball fails with some gmake versions |