Re: pgbench tap tests & minor fixes.

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench tap tests & minor fixes.
Date: 2017-09-04 23:05:09
Message-ID: alpine.DEB.2.20.1709050014550.19424@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Anyway, done with the addition of a "chomp" parameter, leaving only the
> TAP test changes to consider.

Ok, thanks.

> I'll set the CF entry back to "waiting on author" pending your
> revisions of those.

See attached.

Removed scalar/array ref hack, plenty [] added everywhere to match.

Removed perl function prototypes.

Does not try to announce the number of tests, just tell when done.

--
Fabien.

Attachment Content-Type Size
pgbench-tap-12.patch text/x-diff 22.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-09-05 00:37:44 Re: pgbench: Skipping the creating primary keys after initialization
Previous Message Jeff Janes 2017-09-04 22:21:16 pg_basebackup behavior on non-existent slot