Re: pgbench tap tests & minor fixes.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench tap tests & minor fixes.
Date: 2017-09-04 21:27:18
Message-ID: 16966.1504560438@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> * I do not think we need expr_scanner_chomp_substring. Of the three
>> existing callers of expr_scanner_get_substring, one is doing a manual
>> chomp afterwards, and the other two need chomps per your patch.

> Ok. I thought that I would get a slap on the hand if I changed the initial
> function, but I get one not for changing it:-)

Well, more for not looking at the other caller and noting it needed
this too. Anyway, done with the addition of a "chomp" parameter,
leaving only the TAP test changes to consider.

I'll set the CF entry back to "waiting on author" pending your
revisions of those.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2017-09-04 21:33:51 Re: WIP: long transactions on hot standby feedback replica / proof of concept
Previous Message Jeff Janes 2017-09-04 21:21:08 Re: pgbench - minor fix for meta command only scripts