Re: Row Level Security Documentation

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Rod Taylor <rod(dot)taylor(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: Row Level Security Documentation
Date: 2017-07-13 09:49:33
Message-ID: alpine.DEB.2.20.1707131103120.20175@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Rod,

> This version of the table attempts to stipulate which section of the
> process the rule applies to.

A few comments about this patch. It applies cleanly, make html is ok.

It adds a summary table which shows for each case what happens. Although
the information can be guessed/infered from the text, I think that a
summary table is a good thing, at least because it breaks an otherwise
dense presentation.

I would suggest the following changes:

The table should be referenced from the description, something like "Table
xxx summarizes the ..."

ISTM that it would be clearer to split the Policy column into "FOR xxx
..." and "USING" or "WITH CHECK", and to merge the rows which have the
same "FOR xxx ..." contents, something like:

POLICY |
---------------+------------+-----
| USING | ...
FOR ALL ... +------------+-----
| WITH CHECK | ...
---------------+------------+-----
FOR SELECT ... | USING | ...

So that it is clear that only ALL & UPDATE can get both USING & WITH
CHECK. This can be done with "morerows=1" on an entry so that it spans
more rows.

For empty cells, maybe a dash would be clearer. Not sure.

--
Fabien

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-07-13 10:57:33 Re: Update description of \d[S+] in \?
Previous Message Amit Langote 2017-07-13 09:34:58 Re: New partitioning - some feedback