From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
Date: | 2017-02-10 07:48:15 |
Message-ID: | alpine.DEB.2.20.1702100847180.27011@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Corey,
> Changes in this patch:
>
> - invalid boolean expression on \if or \elif is treated as if the script
> had a bad \command, so it either stops the script (ON_ERROR_STOP, script
> mode), or just gives the ParseVariableBool error and continues.
>
> - All interactive "barks" removed except for [...]
>
> - remaining error messages are tersed: [...]
Patch applies, make check ok, psql tap test ok.
Yep. At least the code is significantly simpler.
There is a useless space on one end of line in the perl script.
Shouldn't there be some documentation changes to reflect the behavior on
errors? A precise paragraph about that would be welcome, IMHO.
In particular, I suggest that given the somehow more risky "ignore and
keep going whatever" behavior after a syntax error on if in a script,
there should be some advice that on_error_stop should better be activated
in scripts which use \if.
Given that there is no more barking, then having some prompt indication
that the code is inside a conditional branch becomes more important, so
ISTM that there should be some plan to add it.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2017-02-10 08:00:27 | Re: Documentation improvements for partitioning |
Previous Message | Amit Langote | 2017-02-10 07:35:19 | Re: Documentation improvements for partitioning |