Re: PATCH: pgbench allow '=' in \set

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: pgbench allow '=' in \set
Date: 2015-05-07 18:53:06
Message-ID: alpine.DEB.2.10.1505072043230.20788@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Tom,

> I've got doubts about this too: it introduces fundamental inconsistency
> in pgbench itself, which may come back to bite us later. Who's to say
> that '=' will never be a meaningful operator in pgbench expressions?

Hmmm... it would not be an issue as long as '=' is not a unary operator?
If you add "expr '=' expr" in the syntax, there should be no conflict with
the result target "'=' expr" anyway?

I've just tried that and there is no issue raised by bison.

So ISTM that it should not bite later on that ground.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2015-05-07 18:57:08 Re: PATCH: pgbench allow '=' in \set
Previous Message David G. Johnston 2015-05-07 18:51:46 Re: PATCH: pgbench allow '=' in \set