Re: PATCH: pgbench allow '=' in \set

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: pgbench allow '=' in \set
Date: 2015-05-07 18:34:37
Message-ID: 25798.1431023677@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> 2015-05-07 20:18 GMT+02:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:
>> The attached patch just ignores a leading '=' in a pgbench expression.

> It is question :( - it break a consistency with psql

I've got doubts about this too: it introduces fundamental inconsistency
in pgbench itself, which may come back to bite us later. Who's to say
that '=' will never be a meaningful operator in pgbench expressions?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2015-05-07 18:41:17 Re: Auditing extension for PostgreSQL (Take 2)
Previous Message Andres Freund 2015-05-07 18:32:18 Re: INSERT ... ON CONFLICT error messages