Re: PATCH: pgbench - logging aggregated info and transactions at the same time

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: PATCH: pgbench - logging aggregated info and transactions at the same time
Date: 2015-05-02 14:49:53
Message-ID: alpine.DEB.2.10.1505021048190.30090@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> In doLog, the sample rate test should be mixed in the tlogfile condition
> so as to avoid calling rand if there is no logging anyway.
>
> if (tlogfile && sample_rate != 0 && ...)

Oops, wrong logic. Rather:

if (tlogfile && (sample_rate == 0 || ... random stuff))

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2015-05-02 14:58:03 Re: pgsql: Add transforms feature
Previous Message Fabien COELHO 2015-05-02 14:44:22 Re: PATCH: pgbench - logging aggregated info and transactions at the same time