Re: pgsql: pgbench: Add a real expression syntax to \set

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pgbench: Add a real expression syntax to \set
Date: 2015-03-02 19:56:04
Message-ID: alpine.DEB.2.10.1503022050190.24510@sto
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers


> The makefile changes in this do not look right to me. Files that are
> meant to be shipped in the tarball should be removed by make
> maintainer-clean, not an ordinary "make clean" which is what the committed
> patch appears to do. Otherwise, a tarball user without bison installed
> would be cut off at the knees if he did "make clean" or "make distclean";
> but those operations are not supposed to remove files that were in the
> tarball.

Ooops, sorry, I'm probably responsible for the wrong EXTRA_CLEAN. I
definitely did not consider that clean was expected to leave the directory
to be compilable without flex/bison.

--
Fabien.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-03-02 22:02:38 Re: pgsql: pgbench: Add a real expression syntax to \set
Previous Message Tom Lane 2015-03-02 19:38:02 Re: pgsql: pgbench: Add a real expression syntax to \set