Re: pgsql: pgbench: Add a real expression syntax to \set

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pgbench: Add a real expression syntax to \set
Date: 2015-03-02 19:38:02
Message-ID: 8833.1425325082@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> pgbench: Add a real expression syntax to \set

The makefile changes in this do not look right to me. Files that are
meant to be shipped in the tarball should be removed by make
maintainer-clean, not an ordinary "make clean" which is what the committed
patch appears to do. Otherwise, a tarball user without bison installed
would be cut off at the knees if he did "make clean" or "make distclean";
but those operations are not supposed to remove files that were in the
tarball.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2015-03-02 19:56:04 Re: pgsql: pgbench: Add a real expression syntax to \set
Previous Message Robert Haas 2015-03-02 19:29:41 pgsql: pgbench: Add a real expression syntax to \set