| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: gaussian distribution pgbench -- splits v4 |
| Date: | 2014-07-29 07:42:23 |
| Message-ID: | alpine.DEB.2.10.1407290937410.12870@sto |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Robert,
>>> 3. Similarly, I suggest that the use of gaussian or uniform be an
>>> error when argc < 6 OR argc > 6. I also suggest that the
>>> parenthesized distribution type be dropped from the error message in
>>> all cases.
>>
>> I wish to agree, but my interpretation of the previous code is that they
>> were ignored before, so ISTM that we are stuck with keeping the same
>> unfortunate behavior.
>
> I don't agree.
Attached B patch does turn incorrect setrandom syntax into errors instead
of ignoring extra parameters.
First A patch is repeated to help commitfest references.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| gauss_A_4.patch | text/x-diff | 16.0 KB |
| gauss_B_7.patch | text/x-diff | 16.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-07-29 07:59:37 | Re: delta relations in AFTER triggers |
| Previous Message | Marti Raudsepp | 2014-07-29 07:41:33 | Re: delta relations in AFTER triggers |