Re: pgbench --startup option

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench --startup option
Date: 2013-06-25 18:21:59
Message-ID: alpine.DEB.2.02.1306252016350.27845@localhost6.localdomain6
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> OK, I like this idea a lot, but I have a question. Right now, to use
> this, you have to supply the startup SQL on the command line. And
> that could definitely be useful. But ISTM that you might also want to
> take the startup SQL from a file, and indeed you might well want to
> include metacommands in there. Maybe that's getting greedy, but the
> rate at which people are adding features to pgbench suggests to me
> that it won't be long before this isn't enough.
>
> Thoughts?

My 0.02€:

I thought about this point while reviewing the patch, but I did not add it
to the review because ISTM that it would require a lot of changes, and
pgbench is already kind of a mess, IMHO. Also, possibly you would like to
use a script under different assumptions to test them, that would require
the startup string to be out of the script so as to change it easily. So
it would not be that useful.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-06-25 18:26:05 Re: Kudos for Reviewers -- straw poll
Previous Message Alexander Korotkov 2013-06-25 18:18:08 Re: GIN improvements part 3: ordering in index