Re: Failing test in org.postgresql.test.jdbc2.DateTest

On Mon, 28 Feb 2011, Mike Fowler wrote:

> On 23/02/11 18:30, Mike Fowler wrote:
>> On 23/02/11 16:42, I wrote:
>>>
>>> I've attached a patch to do just that and it's been tested with the
>>> following JDKs:
>>>
>>> 1.4.2_19
>>> 1.5.0_22
>>> 1.6.0_21
>>>
>>> Regards,
>>>
>> Oops, hold the phone. The test still broke on 1.6 but I didn't notice the
>> error as the "build succeeded". The year value 23456 causes the test to
>> fail as the maximum year in java.sql.date is 9999. However, when I change
>> the year to 3456 the test fails:
>>
>> [junit] expected:<3456-01-01> but was:<456-01-01>
>
> Turns out there was another place where a date was being set to 23456-01-01,
> which was misinterpreted by the 1.6 java.sql.Date. Attached is the patch that
> brings all the date tests in line with the published API. This has been
> tested on the three JDKs as noted above, and for all three the test output
> is:

This changed somewhere in the 1.6 release because the 1.6.0_11 version I
have here doesn't have any problem with the original code, but clearly our
tests must work with the latest JVM. I've applied your patch to 8.2 and
up in CVS.

Thanks,
Kris Jurka