Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: JoongHyuk Shin <sjh910805(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date: 2026-07-06 22:30:32
Message-ID: akwsiJJ_f0u60j-v@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 06, 2026 at 04:53:44PM +0900, JoongHyuk Shin wrote:
> I would rather drop the errhint from this patch entirely than fold it into
> the errdetail.
> Any objections?

Sounds good here to remove the errhint(). No hint is better than a
potentially wrong hint. Thanks.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mario González Troncoso 2026-07-06 22:31:44 Re: Possible replace of strncpy on xactdesc.c
Previous Message Mario González Troncoso 2026-07-06 22:26:57 Re: Possible replace of strncpy on xactdesc.c