Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

From: JoongHyuk Shin <sjh910805(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date: 2026-07-06 07:53:44
Message-ID: CACSdjfM9JMFfr0H+fYor5Y7Hkxh8_Ap6_5y=8B9ZoVaOh1CFKQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 29, 2026 at 04:16:59PM -0500, Zsolt Parragi wrote:
> Isn't mentioning pg_settings confusing instead of helpful during a
> server restart? With a reload it can help, but when the server can't
> start, hinting that the user should query pg_settings doesn't seem
> that useful.

You're right, and I had missed this. Thanks.

I would rather drop the errhint from this patch entirely than fold it into
the errdetail.
Any objections?

--
JH Shin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-07-06 07:55:19 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Peter Eisentraut 2026-07-06 07:52:19 Re: ci: namespace ccache by PostgreSQL major version