Re: statatt_build_stavalues->LOCAL_FCINFO wrong number

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: statatt_build_stavalues->LOCAL_FCINFO wrong number
Date: 2026-06-29 23:32:30
Message-ID: akMAjiKYaEgl6_Me@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 29, 2026 at 07:13:07PM +0800, jian he wrote:
> "elemtypid" does not appear within the function (mentioned above), so
> "elemtypid" comment is wrong?

Nice catch. These comments missed a refresh when this code has been
reworked. I have bundled that in the patch, while on it.

> The general idea is to add a trailing comma to the last field of each enum.
> We need to add a comma after the last field in enum attribute_stats_argnum,
> clear_attribute_stats_argnum, and extended_stats_exprs_element.

I didn't see a strong need in this one, though..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2026-06-29 23:34:31 Re: Per-thread leak in ECPG's memory.c
Previous Message Kenichiro Tanaka 2026-06-29 23:21:36 Re: Can we use Statistics Import and Export feature to perforamance testing?