Re: statatt_build_stavalues->LOCAL_FCINFO wrong number

On Mon, Jun 29, 2026 at 7:32 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Mon, Jun 29, 2026 at 07:13:07PM +0800, jian he wrote:
> > "elemtypid" does not appear within the function (mentioned above), so
> > "elemtypid" comment is wrong?
>
> Nice catch. These comments missed a refresh when this code has been
> reworked. I have bundled that in the patch, while on it.
>
> > The general idea is to add a trailing comma to the last field of each
> enum.
> > We need to add a comma after the last field in enum
> attribute_stats_argnum,
> > clear_attribute_stats_argnum, and extended_stats_exprs_element.
>
> I didn't see a strong need in this one, though..
>

In all of those cases, the last value of the enum is essentially "how many
distinct values are in this enum", so that last value must always be the
last value, hence not having a trailing ','.