| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tristan Partin <tristan(at)partin(dot)io> |
| Cc: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Warn when io_min_workers exceeds io_max_workers |
| Date: | 2026-06-23 01:29:35 |
| Message-ID: | ajnhfw84reaXgjfO@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 22, 2026 at 10:30:10PM +0000, Tristan Partin wrote:
> The code looks good. I wonder if we should add a test. I could not find
> a similar test for autovacuum for what it's worth.
Hmm, okay. Why not warning in this case, with a message showing up
only once in the worker with ID=0 at startup and reload.
Let's adjust the messages so as the GUC parameters are included as %s
in the error strings, and apply the same thing for the autovacuum
path. A benefit is that we are then able to reduce the translation
work churn with only one message to translate for both. Hence, I'd
suggest to reword the error messages of both as of:
"\"%s\" (%d) should be less than or equal to \"%s\" (%d)",
"guc_max_min", min_val, "guc_min_name", max_val
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-06-23 01:39:42 | md5_password_warnings for password auth with MD5-encrypted passwords |
| Previous Message | Baji Shaik | 2026-06-23 01:27:13 | Re: [PATCH] Warn when io_min_workers exceeds io_max_workers |