Re: [PATCH] Warn when io_min_workers exceeds io_max_workers

From: Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Warn when io_min_workers exceeds io_max_workers
Date: 2026-06-23 02:47:06
Message-ID: CA+fm-RP8wjzJRVAVm8HzymO6FJ_3_-Q9Xn115jA6tKDTEgm-Pg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 22, 2026 at 8:29 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> Let's adjust the messages so as the GUC parameters are included as %s
> in the error strings, and apply the same thing for the autovacuum
> path. A benefit is that we are then able to reduce the translation
> work churn with only one message to translate for both. Hence, I'd
> suggest to reword the error messages of both as of:
> "\"%s\" (%d) should be less than or equal to \"%s\" (%d)",
> "guc_max_min", min_val, "guc_min_name", max_val
>

Thanks for the suggestion, Michael.

Attached v2 with two patches:

0001 - Adds check_io_worker_gucs() with parameterized GUC names (%s)
0002 - Adjusts check_av_worker_gucs() to use the same format

Both now produce the same translatable errmsg pattern:
"\"%s\" (%d) should be less than or equal to \"%s\" (%d)"

Thanks,
Baji Shaik.

Attachment Content-Type Size
v2-0001-Warn-when-io_min_workers-exceeds-io_max_workers.patch application/octet-stream 2.4 KB
v2-0002-Use-parameterized-GUC-names-in-check_av_worker_gucs-.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-06-23 02:47:23 Re: Remove inner joins based on foreign keys
Previous Message Xuneng Zhou 2026-06-23 02:44:40 Re: 048_vacuum_horizon_floor.pl hangs due to wakeup lost inside LockBufferForCleanup