| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bmomjian(at)gmail(dot)com> |
| Subject: | Re: Fix \crosstabview to honor \pset display_true/display_false |
| Date: | 2026-06-19 17:24:31 |
| Message-ID: | ajV67urZ49oBBZvQ@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Jun-19, David G. Johnston wrote:
> Looked a bit closer at printQuery this time; disliking that the if
> condition has an awareness of the implementation of
> printQueryOptDisplayValue since it lists !isnull and ftype != BOOLOID
> explicitly.
>
> How about not touching print.c at all with this patch, moving the
> printQueryOptDisplayValue into crosstabview.c and leaving printQuery alone
> since it is already correct?
That was my reaction also, so I produced this POC patch. I think
print.h needs some more work, and that'd be only for 20.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fix-crosstabview-for-true-false-print.patch | text/x-diff | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-06-19 17:49:45 | check_stack_depth() vs. tail-recursion optimization |
| Previous Message | Tom Lane | 2026-06-19 16:52:37 | Re: fix pg_mkdir_p to tolerate concurrent directory creation |