| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Bruce Momjian <bmomjian(at)gmail(dot)com> |
| Subject: | Re: Fix \crosstabview to honor \pset display_true/display_false |
| Date: | 2026-06-19 15:51:22 |
| Message-ID: | CAKFQuwYOb2F-zuae+Q-epDOVR5YPaqKEZiaeJpbB96uNQMF+kw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2026 at 6:36 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> PFA v2: addressed David’s comments.
>
Looked a bit closer at printQuery this time; disliking that the if
condition has an awareness of the implementation of
printQueryOptDisplayValue since it lists !isnull and ftype != BOOLOID
explicitly.
How about not touching print.c at all with this patch, moving the
printQueryOptDisplayValue into crosstabview.c and leaving printQuery alone
since it is already correct?
David J.
P.S. When we do get to cleaning this up it seems annoying/odd that we
determine whether to apply numeric locale based upon whether the display
alignment for the column is right-aligned or not as opposed to the data
type of the value.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-06-19 16:38:27 | Re: Fix publisher-side sequence permission reporting |
| Previous Message | Andrew Dunstan | 2026-06-19 15:40:52 | Re: fix pg_mkdir_p to tolerate concurrent directory creation |