Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: 2026-06-18 15:49:38
Message-ID: ajQTklv8QArzTp3h@pryzbyj2023
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 18, 2026 at 10:31:11AM +0300, Alexander Korotkov wrote:
> Pushed with your suggestions accepted.

Thanks. When I went back to test this, I merged ~25 partitions that
were all on the same tablespace, but the merged table was created on the
default tablespace.

I tried again with default_tablespace set, but it was ignored. I think
that's wrong. It's good to follow the tablespace of the parent table,
but if it has no tablespace set, default_tablespace should be obeyed.
See surrounding logic in DefineRelation.

I see the docs say this:
+ <command>ALTER TABLE MERGE PARTITION</command> uses the partitioned
+ table itself as the template to construct the new partition.
+ The new partition will inherit the same table access method, persistence
+ type, and tablespace as the partitioned table.

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-06-18 16:05:03 Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
Previous Message Tom Lane 2026-06-18 15:43:38 Re: fix pg_mkdir_p to tolerate concurrent directory creation