| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2026-06-18 07:31:11 |
| Message-ID: | CAPpHfdte=WJQnEnEhf8cKZYE1rT-VfQ2mgh=1dCsCCdSYStSow@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Pavel!
On Tue, Jun 16, 2026 at 4:01 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> > Extending the syntax to accept WITH (...) on new partitions would be a
> > separate, larger feature. Out of scope for this bug fix.
>
> I agree, this is out of scope of a fix.
> Updated test in v2 and overall patch looks good to me.
>
> A couple of wording proposals:
> never gave it -> never gives it
> Merged partitions need their own TOAST table -> A merged partition
> needs its own TOAST table.
> re-stored -> stored
> a short string suffices -> a string over that threshold suffices
Pushed with your suggestions accepted.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-06-18 07:48:54 | Re: Row pattern recognition |
| Previous Message | Ashutosh Sharma | 2026-06-18 07:12:08 | Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication |