Re: pgindent versus struct members and typedefs

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgindent versus struct members and typedefs
Date: 2026-05-06 15:20:26
Message-ID: aftcOkcXCeFKmZbH@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 06, 2026 at 11:17:17AM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> On Wed, May 06, 2026 at 11:02:35AM -0400, Tom Lane wrote:
>>> We already have an INDENT_VERSION bump queued for the
>>> space-between-comma-and-period change. I don't think we need two
>>> bumps in this cycle, as long as we coordinate pushing these changes.
>
>> Okay. I'll go ahead and commit the patches for $subject then, leaving out
>> the version bump.
>
> No, *don't* do it right now. You'll break anyone using the
> in-tree version, or if you also commit the ensuing code changes,
> you'll break anyone using an out-of-tree copy. This stuff all
> needs to go in at once.

Alright. I'll just prepare the patches and post them here for when that
time comes, then.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2026-05-06 15:22:47 Re: Changing the state of data checksums in a running cluster
Previous Message Tom Lane 2026-05-06 15:17:17 Re: pgindent versus struct members and typedefs