small cleanup for s_lock.h

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: small cleanup for s_lock.h
Date: 2026-05-04 21:49:44
Message-ID: afkUeI7UhacZ5ZFm@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed that s_lock.h points to a default implementation of tas() in
tas.s or s_lock.c, but AFAICT there hasn't been a tas() implementation in
s_lock.c since commit 718aa43a4e, and commit 25f36066dd seems to have
removed the last remaining tas.s files. So, I think this is dead code.

I also noticed that HAS_TEST_AND_SET just means that TAS is defined, so I
wrote a 0002 that removes it in favor of checking TAS directly. I'd like
to rewrite the comment at the top of the file, too, but haven't gotten to
that yet. I find it a little misleading, especially because we #error if
TAS isn't defined.

--
nathan

Attachment Content-Type Size
v1-0001-Remove-fallback-declaration-for-tas.patch text/plain 1.0 KB
v1-0002-Remove-HAS_TEST_AND_SET.patch text/plain 3.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-05-04 22:00:02 Re: Serverside SNI support in libpq
Previous Message Sami Imseih 2026-05-04 20:44:57 Re: Track skipped tables during autovacuum and autoanalyze