| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "li(dot)evan(dot)chao" <li(dot)evan(dot)chao(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Serverside SNI support in libpq |
| Date: | 2026-05-04 22:00:02 |
| Message-ID: | 368855.1777932002@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 4 May 2026, at 21:22, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> As a side matter, "load_host" seems like a remarkably generic name
>> that conveys little about what it actually does,
> It's following the naming convention of load_hba() which reads pg_hba.conf, and
> load_ident() which reads pg_ident.conf - thus load_hosts() for the function
> that reads pg_hosts.conf. Perhaps load_pg_hosts_conf() or load_hosts_config()
> would convey more meaning?
Hmm, okay. I'd prefer a more specific name, but it wouldn't make
much sense unless we also rename those two. That's probably more
code churn than is justified.
I'll push the thing for moving/using the typedef, but leave the
function name alone.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-05-04 22:11:02 | Re: small cleanup for s_lock.h |
| Previous Message | Nathan Bossart | 2026-05-04 21:49:44 | small cleanup for s_lock.h |