Re: Replace some %llu remnants in the tree

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Replace some %llu remnants in the tree
Date: 2025-06-13 00:13:08
Message-ID: afgcmjqyacdui6f6ttwdke4neog3qkuifpkftivvygqntpjxx4@vzgnrfjqrpjt
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-06-09 12:59:20 +0900, Michael Paquier wrote:
> While hacking a different patch, I've noticed that a couple of %llu
> did not get the PRIu64 call in the AIO code, and I don't see why we
> could not switch them. These have been introduced in commits that got
> into the tree after Peter's 15a79c73111f.

FWIW, I find it utterly unsurpising that new users of %llu were introduced
after 15a79c73111f. For one, 15a79c73111f explicitly says "(minimal trial)" in
the subject line, it'd have hardly been sensible to introduce PRI* uses at
that point. Only a0ed19e0a9e, changed most of the uses (after e.g. the
io_uring uses were introduced). For another, how is everyone even supposed to
even have known about this new policy, it was just discussed in a long thread,
at a very busy time? Even now I suspect we'll grow more %ll[ud] users, it's
after all what we've been trained to do for quite a while now.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-06-13 00:33:26 Re: pg_dump --with-* options
Previous Message Michael Paquier 2025-06-13 00:01:43 Re: Replace some %llu remnants in the tree