Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.
Date: 2017-05-17 15:55:11
Message-ID: afb26896-ec58-2fe1-47ea-e1e855bd8fb7@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 5/17/17 10:14, Tom Lane wrote:
> What I was concerned about was that pgindent will reindent the second
> line so that it's impossible to tell whether the spacing is correct.

pgindent moving string continuations to the left is a completely
terrible behavior anyway and we should look into changing that. Just
look at the mess it makes out of SELECT queries in pg_dump.c.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-05-17 16:24:01 Re: pgsql: Tag refs/tags/REL_10_BETA1 was created
Previous Message Peter Eisentraut 2017-05-17 15:52:10 Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-05-17 16:00:45 Re: Improvement in log message of logical replication worker
Previous Message Remi Colinet 2017-05-17 15:52:55 Re: [PATCH v2] Progress command to monitor progression of long running SQL queries