| From: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Date: | 2017-05-17 21:03:05 |
| Message-ID: | VI1PR03MB11996853FB1EC6319A48BA76F2E70@VI1PR03MB1199.eurprd03.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2017-05-17 17:55, Peter Eisentraut wrote:
> On 5/17/17 10:14, Tom Lane wrote:
>> What I was concerned about was that pgindent will reindent the second
>> line so that it's impossible to tell whether the spacing is correct.
>
> pgindent moving string continuations to the left is a completely
> terrible behavior anyway and we should look into changing that. Just
> look at the mess it makes out of SELECT queries in pg_dump.c.
If I remember correctly, it tries to right-align string literals to
whatever -l ("Maximum length of an output line") was set to.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-05-17 21:13:47 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Previous Message | Piotr Stefaniak | 2017-05-17 20:54:48 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2017-05-17 21:10:53 | Re: Pulling up more complicated subqueries |
| Previous Message | Piotr Stefaniak | 2017-05-17 20:54:48 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |