Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY

From: Alvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, "L(dot) pgsql-hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY
Date: 2026-04-30 22:03:05
Message-ID: afPPnTzNNC3EupUA@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Apr-26, Antonin Houska wrote:

> I see you actually refer to the correct tests. I see no failure now as
> well. I'll try to make the tests more stable. Sorry for the confusion.

So, the reason this wasn't failing for me is that I had default TOAST
compression lz4, and the test case wasn't reaching size for being made
external, as opposed to pglz. I changed the test to specify pglz
compression explicitly. I also added some dropped columns and one more
toast column. (On my machine, this expanded test fails for several
rows, not just one, when the fix is deactivated.) I fear the buildfarm
may end up showing other failures, but there's no way to know other than
to try.

Thanks, Satya, for reporting the bug.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"In fact, the basic problem with Perl 5's subroutines is that they're not
crufty enough, so the cruft leaks out into user-defined code instead, by
the Conservation of Cruft Principle." (Larry Wall, Apocalypse 6)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-04-30 22:08:54 Re: Startup process deadlock: WaitForProcSignalBarriers vs aux process
Previous Message Melanie Plageman 2026-04-30 21:57:19 Re: Two issues leading to discrepancies in FSM data on the standby server