From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
Cc: | Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Subject: | Re: Fix around conn_duration in pgbench |
Date: | 2021-07-29 17:01:08 |
Message-ID: | af81f04e-6e87-4ba3-d37d-5fed67c5cdd6@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021/07/29 2:23, Fujii Masao wrote:
>
>
> On 2021/07/28 16:15, Yugo NAGATA wrote:
>>> I found another disconnect_all().
>>>
>>> /* XXX should this be connection time? */
>>> disconnect_all(state, nclients);
>>>
>>> The measurement is also not necessary here.
>>> So the above comment should be removed or updated?
>>
>> I think this disconnect_all will be a no-op because all connections should
>> be already closed in threadRun(), but I left it just to be sure that
>> connections are all cleaned-up. I updated the comment for explaining above.
>>
>> I attached the updated patch. Could you please look at this?
>
> Thanks for updating the patch! LGTM.
This patch needs to be back-patched because it fixes the bug
in measurement of disconnection delays. Thought?
But the patch fails to be back-patched to v13 or before because
pgbench's time logic was changed by commit 547f04e734.
Do you have the patches that can be back-patched to v13 or before?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2021-07-29 17:05:21 | Re: pg_upgrade does not upgrade pg_stat_statements properly |
Previous Message | David G. Johnston | 2021-07-29 17:00:12 | Re: pg_upgrade does not upgrade pg_stat_statements properly |