| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Subject: | Re: Fix around conn_duration in pgbench |
| Date: | 2021-07-28 17:23:22 |
| Message-ID: | 633102a8-7118-45b1-306a-628cec94f199@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/07/28 16:15, Yugo NAGATA wrote:
>> I found another disconnect_all().
>>
>> /* XXX should this be connection time? */
>> disconnect_all(state, nclients);
>>
>> The measurement is also not necessary here.
>> So the above comment should be removed or updated?
>
> I think this disconnect_all will be a no-op because all connections should
> be already closed in threadRun(), but I left it just to be sure that
> connections are all cleaned-up. I updated the comment for explaining above.
>
> I attached the updated patch. Could you please look at this?
Thanks for updating the patch! LGTM.
Barring any objection, I will commit the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-07-28 17:28:08 | Re: Have I found an interval arithmetic bug? |
| Previous Message | Tom Lane | 2021-07-28 17:16:19 | Re: CREATE SEQUENCE with RESTART option |