[patch] remove strver's leftover from error message in Solution.pm

From: Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [patch] remove strver's leftover from error message in Solution.pm
Date: 2021-06-25 17:47:50
Message-ID: af79ee1b-9962-b299-98e1-f90a289e19e6@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

in src/tools/msvc/Solution.pm (in the current master) there is a
leftover from the past:
> confess "Bad format of version: $self->{strver}\n";

strver has been gone since 8f4fb4c6 in 2019, so I suggest an obvious
one-line fix in the patch attached:

diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index a7b8f720b55..fcb43b0ca05 100644
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -176,7 +176,7 @@ sub GenerateFiles

if ($package_version !~ /^(\d+)(?:\.(\d+))?/)
{
- confess "Bad format of version: $self->{strver}\n";
+ confess "Bad format of version: $package_version\n";
}
$majorver = sprintf("%d", $1);
$minorver = sprintf("%d", $2 ? $2 : 0);

I think this should be backported to REL_13_STABLE, but not to
REL_12_STABLE and earlier, where strver was still present.

--
Anton Voloshin,
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru

Attachment Content-Type Size
remove-strver.patch text/x-patch 469 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2021-06-25 19:56:30 Re: Emit namespace in post-copy output
Previous Message Alvaro Herrera 2021-06-25 15:55:13 Re: Some incorrect logs in TAP tests of pgbench