| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)kurilemu(dot)de |
| Subject: | Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY |
| Date: | 2026-04-17 21:32:48 |
| Message-ID: | aeKnABrX4ShBtHkg@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 17, 2026 at 10:40:39AM -0700, SATYANARAYANA NARLAPURAM wrote:
> I started with that but tried to follow the existing code pattern. This
> LGTM.
> Please add a comment as well.
Hmm. I was reading restore_tuple(), and could it make sense to expand
a bit more the tests so as more types of varlena pointers could be
checked in this routine? I am taking about MAIN, EXTENDED and
EXTERNAL, so as we could check more patterns with in-line
[non-]compressed, and external [non-]compressed, counting for the four
different possible patterns that could lead to repacked data. See for
example strings.sql for such tests, that could be used as base
inspiration.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-04-17 21:35:54 | Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb() |
| Previous Message | Jelte Fennema-Nio | 2026-04-17 20:10:12 | Re: Add editorconfig support for Postgres spec files |