| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Remove libpq.rc, use win32ver.rc for libpq |
| Date: | 2019-12-27 16:25:58 |
| Message-ID: | ad505e61-a923-e114-9f38-9867d161073f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I was wondering why we have a separate libpq.rc for libpq and use
win32ver.rc for all other components. I suspect this is also a leftover
from the now-removed client-only Windows build. With a bit of tweaking
we can use win32ver.rc for libpq as well and remove a bit of duplicative
code.
I have tested this patch with MSVC and MinGW.
I've also added some comments and a documentation link to be able to
understand this business a bit better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-libpq.rc-use-win32ver.rc-for-libpq.patch | text/plain | 10.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-12-27 16:29:47 | Re: use CLZ instruction in AllocSetFreeIndex() |
| Previous Message | Tom Lane | 2019-12-27 16:05:22 | Re: use CLZ instruction in AllocSetFreeIndex() |