| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: remove bits* types |
| Date: | 2026-03-30 17:00:01 |
| Message-ID: | acqsERCb1t8OCZpG@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 30, 2026 at 12:41:09PM -0400, Melanie Plageman wrote:
> On Thu, Mar 26, 2026 at 2:21 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> On Wed, Mar 25, 2026 at 05:27:34PM +0100, Peter Eisentraut wrote:
>> > I'm mildly in favor of removing them. But it appears there is no consensus.
>>
>> Same here. While it still doesn't look like anybody is totally opposed to
>> the idea, you are right that there is no consensus.
>
> I really wish we would remove them. I want fewer confusing typedefs in
> the code -- not more. I'm quite sad that as of 1bd6f22f43ac1b we are
> now using them more widely (and publicly), and I feel that was done
> without consensus. It should just use a regular uint32 -- like other
> places we do this (e.g. scan_begin() amongst many others).
Thanks for the heads-up. Here's a rebased patch.
With Melanie's note, there are at least 4 votes in favor of this patch
(Andres, me, Peter, and Melanie). AFAICT Michael is +/-0, Álvaro and Tom
are -1 (or somewhere in the vicinity), and Robert seems ambivalent. Hm...
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-remove-bits-types.patch | text/plain | 100.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-30 17:07:32 | Re: remove bits* types |
| Previous Message | Pavlo Golub | 2026-03-30 16:42:29 | Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements |