Re: Add support for automatically updating Unicode derived files

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for automatically updating Unicode derived files
Date: 2020-01-09 09:16:19
Message-ID: acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-01-03 15:13, John Naylor wrote:
> On Thu, Dec 26, 2019 at 12:39 PM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>
>> On 2019-12-19 23:48, John Naylor wrote:
>>> I would print out the full boilerplate like for other generated headers.
>>
>> Hmm, you are probably comparing with
>> src/common/unicode/generate-unicode_norm_table.pl, but other file
>> generating scripts around the tree print out a small header in the style
>> that I have. I'd rather adjust the output of
>> generate-unicode_norm_table.pl to match those. (It's also not quite
>> correct to make copyright claims about automatically generated output.)
>
> Hmm, the scripts I'm most familiar with have full headers. Your point
> about copyright makes sense, and using smaller file headers would aid
> readability of the scripts, but I also see how others may feel
> differently.
>
> v2 looks good to me, marked ready for committer.

Committed, thanks.

I have added a little tweak so that it works also without --with-python,
to avoid gratuitous annoyances.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-01-09 09:20:14 Re: Unicode normalization SQL functions
Previous Message Simon Riggs 2020-01-09 09:07:01 Re: Recognizing superuser in pg_hba.conf