Re: Add support for automatically updating Unicode derived files

From: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for automatically updating Unicode derived files
Date: 2020-01-03 14:13:53
Message-ID: CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 26, 2019 at 12:39 PM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 2019-12-19 23:48, John Naylor wrote:
> > I would print out the full boilerplate like for other generated headers.
>
> Hmm, you are probably comparing with
> src/common/unicode/generate-unicode_norm_table.pl, but other file
> generating scripts around the tree print out a small header in the style
> that I have. I'd rather adjust the output of
> generate-unicode_norm_table.pl to match those. (It's also not quite
> correct to make copyright claims about automatically generated output.)

Hmm, the scripts I'm most familiar with have full headers. Your point
about copyright makes sense, and using smaller file headers would aid
readability of the scripts, but I also see how others may feel
differently.

v2 looks good to me, marked ready for committer.

--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-01-03 14:14:27 distinguish index cost component from table component
Previous Message Tom Lane 2020-01-03 14:10:36 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.